Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update datum to v0.2.1-beta #1865

Merged
merged 1 commit into from
Nov 28, 2024
Merged

update datum to v0.2.1-beta #1865

merged 1 commit into from
Nov 28, 2024

Conversation

Retropex
Copy link

@Retropex Retropex commented Nov 28, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ datum/docker-compose.yml External port mapping "23334:23334":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Legend

Symbol Description
❌ Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Nov 28, 2024

Awesome, thanks @Retropex! I'll be setting up my new bitaxe gamma in just a bit here. Will get that done and then test.

@nmfretz
Copy link
Contributor

nmfretz commented Nov 28, 2024

Everything working great @Retropex. Thanks a bunch for the update 🤝

@nmfretz nmfretz merged commit 0a4d229 into getumbrel:master Nov 28, 2024
1 check passed
@Retropex Retropex deleted the datum2.1 branch November 28, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Retropex @nmfretz